[tor-bugs] #26498 [Applications/Tor Browser]: Fix bn-BD and es-AR locale for Tor Browser

[Tor Bug Tracker & Wiki]

#26498: Fix bn-BD and es-AR locale for Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201810R =>
 * status:  needs_review => needs_revision


Comment:

 Okay, I tested both locales on a Linux and a Windows system. Here is what
 I did to build the bundles:

 1) I created patches with `git format-patch` for Torbutton and Tor
 Launcher and applied them during the rbm build process
 2) I patched `rbm.conf` to just build `bn-BD` and `es-AR` bundles in
 addition to `en-US` ones
 3) I committed the Torbutton patch locally
 4) I updated my local Torbutton repo to pick up possibly missing `bn-BD`
 and `es-AR` language strings
 5) I created a patch (with `git format-patch`) and applied the updated
 translations on top of the Torbutton patch up for review during the rbm
 build.

 The `bn-BD` bundle seems to be missing a font or something as the title
 bar is just gibberish on Linux (see attachment). On Windows this does not
 seem to be an issue. I additionally found #28196 which is unrelated to
 this bug, though.

 The `es-AR` bundle is neither running on Linux nor on Windows I get
 {{{
 Error de análisis XML: entidad indefinida
 Ubicación: chrome://browser/content/browser.xul
 Línea 41, columna 1:<window id="main-window"
 }}}
 just before the main browser window pops up.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26498#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online