[tor-bugs] #27273 [Core Tor/Tor]: ASan fails to link on Travis due to rustc and linker arguments

[Tor Bug Tracker & Wiki]

#27273: ASan fails to link on Travis due to rustc and linker arguments
--------------------------+------------------------------------
 Reporter:  alexcrichton  |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:  #25386        |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:13 alexcrichton]:
 > This'll be able to work on stable starting with the 1.31.0 release,
 happening in early December. The bug fixes should be riding the trains
 soon to beta (happening in the next day or so). Once that happens you can
 switch to `beta` to ensure nightly features don't slip in by accident!

 I think we might benefit from always building with stable, beta and
 nightly rust:
 * If we always build Mac and Linux with nightly, we'll catch rust bugs
 early, before they ride the trains.
 * If we always build Linux with beta and stable, then we'll catch nightly
 features, and also catch any bugs that slip into beta while there's still
 a chance to fix them. (We try to minimise our Mac builds, because they're
 slow.)

 We currently have the following rust builds:
 * Linux, rust stable, frozen rust dependencies, no hardening
 * Mac, rust stable, frozen rust dependencies, no hardening
 * Linux, rust stable, online rust dependencies, no hardening, distcheck
 * Linux, rust stable, frozen rust dependencies, no hardening, disable
 module dirauth

 TODO: when we merge this branch, we could switch rust versions and turn on
 hardening for the first three builds:
 * Linux, rust nightly, frozen rust dependencies, hardening
 * Mac, rust nightly, frozen rust dependencies, hardening
 * Linux, rust beta, online rust dependencies, hardening, distcheck

 TODO: open a ticket to switch on hardening for the rust stable build in
 December:
 * Linux, rust stable, frozen rust dependencies, hardening, disable module
 dirauth

 Alex/Nick, I can update the rust versions and hardening in Travis config
 if you'd like. Or I can review your commits.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27273#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online