[tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

[Tor Bug Tracker & Wiki]

#25013: Move TorButton code to the tor browser repository
----------------------------------------------+--------------------------
 Reporter:  igt0                              |          Owner:  tbb-team
     Type:  defect                            |         Status:  new
 Priority:  High                              |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201810  |  Actual Points:
Parent ID:  #10760                            |         Points:
 Reviewer:  gk, sysrqb, mcs,                  |        Sponsor:
----------------------------------------------+--------------------------
Changes (by gk):

 * status:  needs_review => new


Comment:

 Replying to [comment:38 igt0]:
 > These two patches are the first steps to move tor button to firefox, it
 adds a new file called jar.mn that generates the chrome.manifest and
 update the code removing an unecessary import.
 >
 > ** bug 25013: Add Gecko build system infrastructure into tor button**
 >
 https://github.com/igortoliveira/torbutton/commit/a86d5bbea745ff41e072a049994161eeca642e01
 >
 > **bug 25013: Remove non needed import, it is already available in the
 window object**
 >
 https://github.com/igortoliveira/torbutton/commit/ceba9655fff4e454bb0c4003d4d3e849abb5033c
 >
 > The next step is adding torbutton as submodule in the toolkit directory
 and update its moz.build file.

 I guess you have that outlined in your proposal but why toolkit and not
 the browser directory where all the other extensions are? Let's clear
 review for now as other, crucial pieces are missing. The review of the
 parts above might depend on them being available.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online