[tor-bugs] #27741 [Core Tor/Tor]: too many arguments in rust protover_compute_vote()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Oct 22 04:28:47 UTC 2018
#27741: too many arguments in rust protover_compute_vote()
-------------------------------------------------+-------------------------
Reporter: cyberpunks | Owner: nickm
Type: defect | Status:
| needs_review
Priority: Very High | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.6
Severity: Normal | Resolution:
Keywords: 035-must, protover, memory-safety, | Actual Points:
033-backport, 034-backport |
Parent ID: #27739 | Points:
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
The 0.3.3 pull request is:
https://github.com/torproject/tor/pull/346
Replying to [comment:16 teor]:
> Replying to [comment:14 cyberpunks]:
> > rustfmt actually says the `bug27741_033` branch should put the
function arguments all in one line, since they fit within 100 characters
now.
>
> We only applied rustfmt in 0.3.5, so I made a separate branch for 0.3.5
and later.
> See `bug27741_035` on https://github.com/teor2345/tor.git
>
> GitHub is having issues, so I can't open a pull request:
> https://status.github.com/messages
The 0.3.5 pull request is:
https://github.com/torproject/tor/pull/431
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27741#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list