[tor-bugs] #28127 [Core Tor/Tor]: Hidden service option HiddenServiceAuthorizeClient is incompatible with version 3

[Tor Bug Tracker & Wiki]

#28127: Hidden service option HiddenServiceAuthorizeClient is incompatible with
version 3
--------------------------------+------------------------------
 Reporter:  pege                |          Owner:  (none)
     Type:  defect              |         Status:  new
 Priority:  Medium              |      Component:  Core Tor/Tor
  Version:  Tor: 0.3.5.1-alpha  |       Severity:  Normal
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
 When upgrading from 0.3.4 to 0.3.5 hidden services that have
 HiddenServiceAuthorizeClient set break. My understanding is that already
 created onion services should remain v2 and new services are created as
 v3. However, this doesn't appear to be the case if client authorization is
 active.

 == Steps to reproduce:

 1. Create an a hidden service like this in 0.3.4:

 {{{
 HiddenServiceDir /var/lib/tor/hidden_service/
 HiddenServiceAuthorizeClient stealth client1,client2
 HiddenServicePort 45325 127.0.0.1:22
 }}}

 2. Upgrade to 0.3.5

 3. You'll see this error:

 {{{
 Oct 19 18:18:35 rasp3-l5 systemd[1]: Starting Anonymizing overlay network
 for TCP...
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.243 [notice] Tor
 0.3.5.3-alpha running on Linux with Libevent 2.0.21-stable, OpenSSL
 1.1.0f, Zlib 1.2.8, Liblzma 5.2.2, and Libzstd 1.1.2.
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.243 [notice] Tor
 can't help you if you use it wrong! Learn how to be safe at
 https://www.torproject.org/download/download#warning
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.243 [notice] This
 version is not a stable Tor release. Expect more bugs than usual.
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.243 [notice] Read
 configuration file "/usr/share/tor/tor-service-defaults-torrc".
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.243 [notice] Read
 configuration file "/etc/tor/torrc".
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.254 [warn] Hidden
 service option HiddenServiceAuthorizeClient is incompatible with version 3
 of service in /var/lib/tor/hidden_service/
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.254 [warn] Failed to
 parse/validate config: Failed to configure rendezvous options. See logs
 for details.
 Oct 19 18:18:36 rasp3-l5 tor[13098]: Oct 19 18:18:36.254 [err] Reading
 config failed--see warnings above.
 }}}

 In 0.3.5, setting {{{HiddenServiceVersion 2}}} and removing it again has
 the same effect.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28127>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online