[tor-bugs] #27629 [Core Tor/Tor]: add len argument to consensus parsing functions
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Oct 19 14:23:33 UTC 2018
#27629: add len argument to consensus parsing functions
--------------------------+------------------------------------
Reporter: cyberpunks | Owner: (none)
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.6.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #27244 | Points:
Reviewer: mikeperry | Sponsor: Sponsor8
--------------------------+------------------------------------
Comment (by cyberpunks):
Replying to [comment:11 ahf]:
> why is this needed in relation to the patches in #27244 ? This seems
like a lot of clean up patches in related code?
It's the same work. That's why it's a child ticket. All these functions
assumed strings are NUL-terminated, which they aren't if passed something
mmap'd, so they need explicit length added.
The branch parselen1-on-ticket27247 finishes the job of #27244. All this
stuff needs to be rebased now though.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27629#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list