[tor-bugs] #27443 [Applications/Tor Browser]: Update Firefox RBM config and build for Android

[Tor Bug Tracker & Wiki]

#27443: Update Firefox RBM config and build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201810                           |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 I think those comments are still valid for commit
 `2276a44b14edf82f0f44ac98c50597a8637e5883`:

 > * could you add a comment explaining why we need the
 `projects/firefox/gradle.patch`? Maybe this is something we want to patch
 in `tor-browser.git` directly?
 > * could you explain why we need `projects/firefox/android.patch`? It
 seems to be removing some code behind `#if defined(GP_OS_linux)` and
 forcing use of the code previously behind `#elif defined(GP_OS_android)`.
 Shouldn't `defined(GP_OS_linux)` be false and `defined(GP_OS_android)` be
 true in the android build?

 And also:
 * the patch is adding an `i` after the creation of the martools zip file.
 Those lines should be indented for the `IF`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27443#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online