[tor-bugs] #27928 [Core Tor/Tor]: Refrain from listener rebinding when address families differ

[Tor Bug Tracker & Wiki]

#27928: Refrain from listener rebinding when address families differ
------------------------------+---------------------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.5.1-alpha
     Severity:  Normal        |   Keywords:  bind port switching
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+---------------------------------
 In `retry_listener_ports`, we check if port matches exactly and *one* of
 the addresses is a wildcard address:
 {{{
 2795         const int may_need_rebind =
 2796           port_matches_exact &&
 bool_neq(tor_addr_is_null(&wanted->addr),
 2797
 tor_addr_is_null(&conn->addr));
 }}}

 We should also check if address family is the same between old and new
 listener. If they differ, we don't need to do rebinding. See discussion on
 #17873.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27928>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online