[tor-bugs] #28615 [Metrics/Library]: Additional @type annotation

[Tor Bug Tracker & Wiki]

#28615: Additional @type annotation
-----------------------------+------------------------------
 Reporter:  atagar           |          Owner:  metrics-team
     Type:  enhancement      |         Status:  new
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 Adding a `@type` annotation for detached signatures sounds reasonable.

 But I'm less clear about the other three. A status entry is not a
 descriptor. It is ''part'' of another descriptor. In Metrics Library we
 have `NetworkStatusEntry` for status entry, but it's explicitly marked as
 not being a descriptor type of its own.

 Wouldn't it be sufficient to pass the `@type` annotation of the network
 status containing the status entry to Stem?

 Asked differently, if we make the status entry a descriptor type of its
 own, why would we not do the same with `dir-source` entries
 (`DirSourceEntry` in Metrics Library), `directory-signature` entries
 (`DirectorySignature` in Metrics Library)? (I'm not suggesting we do this,
 but what would we tell somebody suggesting this after defining descriptor
 types for the various status entries?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28615#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online