[tor-bugs] #28612 [Core Tor/Tor]: Tor start via Windows service fails

[Tor Bug Tracker & Wiki]

#28612: Tor start via Windows service fails
--------------------------------+------------------------------------
 Reporter:  Vort                |          Owner:  (none)
     Type:  defect              |         Status:  new
 Priority:  Medium              |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor        |        Version:  Tor: 0.3.5.5-alpha
 Severity:  Normal              |     Resolution:
 Keywords:  windows nt-service  |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------------

Comment (by Vort):

 Tried to insert some code at `cpuworker.c:501` to catch the bug -> no
 result. Reverted my changes -> no assertion anymore.
 But here is what says gdb now. Maybe it is more related than `cpuworker.c`
 problem:
 {{{
 Attaching to process 17568
 [New Thread 17568.0x7884]
 [New Thread 17568.0x7518]
 [New Thread 17568.0x8b90]
 [New Thread 17568.0xccb0]
 [New Thread 17568.0x8b4c]
 [New Thread 17568.0xd754]
 Reading symbols from D:\Tor\tor.exe...done.
 Continuing.
 [Thread 17568.0xd754 exited with code 0]

 Thread 4 received signal SIGFPE, Arithmetic exception.
 [Switching to Thread 17568.0xccb0]
 0x0000000000527af1 in token_bucket_raw_refill_steps (elapsed=54536462,
     cfg=0x658800 <global_bucket>, bucket=0x658808 <global_bucket+8>)
     at src/lib/evloop/token_bucket.c:90
 90        if (elapsed > gap / cfg->rate) {
 (gdb) bt
 #0  0x0000000000527af1 in token_bucket_raw_refill_steps (elapsed=54536462,
     cfg=0x658800 <global_bucket>, bucket=0x658808 <global_bucket+8>)
     at src/lib/evloop/token_bucket.c:90
 #1  token_bucket_rw_refill (bucket=0x658800 <global_bucket>,
     now_ts=now_ts at entry=872583402) at src/lib/evloop/token_bucket.c:206
 #2  0x000000000040650f in connection_bucket_refill_single (conn=0x1552f60,
     now_ts=872583402) at src/core/mainloop/connection.c:3436
 #3  0x000000000040df78 in connection_handle_read_impl (conn=0x1552f60)
     at src/core/mainloop/connection.c:3539
 #4  connection_handle_read (conn=conn at entry=0x1552f60)
     at src/core/mainloop/connection.c:3647
 #5  0x0000000000413b10 in conn_read_callback (fd=<optimized out>,
     event=<optimized out>, _conn=0x1552f60)
     at src/core/mainloop/mainloop.c:870
 #6  0x00000000621d4999 in ?? () from D:\Tor\libevent-2-1-6.dll
 #7  0x00000000621d5504 in ?? () from D:\Tor\libevent-2-1-6.dll
 #8  0x000000000041496f in run_main_loop_once ()
     at src/core/mainloop/mainloop.c:2926
 #9  run_main_loop_until_done () at src/core/mainloop/mainloop.c:2988
 #10 do_main_loop () at src/core/mainloop/mainloop.c:2883
 #11 0x00000000004f4886 in nt_service_body (argc=<optimized out>,
     argv=<optimized out>) at src/app/main/ntmain.c:301
 #12 0x000007fefdb1a82d in SECHOST!RegisterServiceCtrlHandlerExA ()
    from C:\Windows\SYSTEM32\sechost.dll
 #13 0x00000000778759cd in KERNEL32!BaseThreadInitThunk ()
    from C:\Windows\system32\kernel32.dll
 #14 0x00000000779d385d in ntdll!RtlUserThreadStart ()
    from C:\Windows\SYSTEM32\ntdll.dll
 #15 0x0000000000000000 in ?? ()
 Backtrace stopped: previous frame inner to this frame (corrupt stack?)
 (gdb)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28612#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online