[tor-bugs] #28466 [Applications/rbm]: rbm does not correctly apply git submodule URL changes

[Tor Bug Tracker & Wiki]

#28466: rbm does not correctly apply git submodule URL changes
--------------------------------------------+------------------------------
 Reporter:  boklm                           |          Owner:  boklm
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Applications/rbm                |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201811R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201811R
 * status:  new => needs_review


Comment:

 Branch `test_bug_28466` can be used to reproduce the issue:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=test_bug_28466&id=0c944e04e45b4e45bece7c18d21857a64989ee1b

 {{{
 $ ./rbm/rbm tar bug_28466 --target tor-launcher
 Cloning into 'bug_28466'...
 remote: Counting objects: 7461, done.
 remote: Compressing objects: 100% (1211/1211), done.
 remote: Total 7461 (delta 764), reused 0 (delta 0)
 Receiving objects: 100% (7461/7461), 3.51 MiB | 641.00 KiB/s, done.
 Resolving deltas: 100% (4731/4731), done.
 Checking connectivity... done.
 Submodule 'rbm' (https://git.torproject.org/builders/rbm.git) registered
 for path 'rbm'
 Cloning into 'rbm'...
 remote: Counting objects: 2040, done.
 remote: Total 2040 (delta 0), reused 0 (delta 0)
 Receiving objects: 100% (2040/2040), 495.51 KiB | 455.00 KiB/s, done.
 Resolving deltas: 100% (1174/1174), done.
 Checking connectivity... done.
 Submodule path 'rbm': checked out
 '5c89374df7957238a9565c0b938ee3f30f880438'
 Created /home/user/work/tor/tor-browser-build/out/bug_28466/bug_28466-tor-
 launcher.tar.gz

 $ ./rbm/rbm tar bug_28466 --target torbutton
 Error: Error running git submodule update:
 fatal: reference is not a tree: a41034ced7a6c0fe590320d9da61d15df1fef42f
 Unable to checkout 'a41034ced7a6c0fe590320d9da61d15df1fef42f' in submodule
 path 't'
 }}}

 There is a commit fixing this issue in branch `bug_28466`:
 https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_28466&id=eb500fa9467fb4d7229c9ca87f202ef18603d023

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28466#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online