[tor-bugs] #27993 [Core Tor/Tor]: craft a git pre push hook that declines to receive fixup! commits?
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Nov 20 18:31:57 UTC 2018
#27993: craft a git pre push hook that declines to receive fixup! commits?
----------------------------+------------------------------------
Reporter: arma | Owner: (none)
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: technical-debt | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
----------------------------+------------------------------------
Changes (by dgoulet):
* status: merge_ready => needs_revision
Comment:
Replying to [comment:9 nickm]:
> Okay. Should we have the script tell you about --no-verify in that
case? Let's assume that the user will periodically forget how to use git.
Yup agree it could output it in the error message. So if I summarize, we
need three changes:
1. Rename it to `pre-push.git-hook` in `scripts/maint/`
2. Add an indication to the `--no-verify` option to the error.
3. Comment at the start of the file that tells you how to install the
hook.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27993#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list