[tor-bugs] #28483 [Applications/Tor Browser]: Modify Android Toolchain API Version
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Nov 20 08:30:28 UTC 2018
#28483: Modify Android Toolchain API Version
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: defect | Status:
| needs_information
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, tbb-mobile, TBA-a2, | Actual Points:
TorBrowserTeam201811 |
Parent ID: #26693 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:4 sisbell]:
> Replying to [comment:3 gk]:
>
>
> > What is the Rust angle here? That is, why do we need to set the API to
16 for building Rust? Building Rust and running Tor Browser for Android
with `--api 26` is working fine for me.
>
> I would expect that it would work but I was thinking we should compile
our rust libraries with the same version of the NDK as the rest of the
firefox native code.
>
> Rust is using --set=target.armv7-linux-
androideabi.cc=$ANDROID_NDK_HOME/arm/bin/arm-linux-androideabi-gcc which
is pointing to the location we created using with the
make_standalone_toolchain script.
>
> Or am I missing the question?
I think you missed the question. :) Sure, we should build everything with
the same NDK version if possible. But: switching from `--api 26` to `--api
16` is not because there is something wrong with Rust in particular (as
your comment indicates) but because we want to use `--api 16` for the
whole project. Maybe instead of the comment you currently have we could
write something like "API 16 is the minimum we currently support for Tor
Browser on Android."
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28483#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list