[tor-bugs] #27100 [Core Tor/Tor]: report connection to PT SOCKS proxy separately from OR connection

[Tor Bug Tracker & Wiki]

#27100: report connection to PT SOCKS proxy separately from OR connection
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  ahf
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-subtask, 035-triaged-    |  Actual Points:
  in-20180711, socks, pt, s8-bootstrap           |
Parent ID:  #28018                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by catalyst):

 I'm still looking at how best to do this.

 It looks like `connection_or_finished_connecting()` is called when the TCP
 `connect()` succeeds, whether it's directly to a relay or to the TCP
 listener of a proxy (which could be a PT proxy or a firewall-bypass
 proxy). It looks like the call
 `control_event_bootstrap(BOOTSTRAP_STATUS_HANDSHAKE, 0)` is like many
 other parts of the bootstrap reporting in that it reports an anticipated
 next step, even if there might be multiple intermediate unreported steps
 yet to happen.

 It's probably better to report the (TLS?) handshaking when it actually
 starts to happen, which is probably down in
 `connection_tls_start_handshake()`.

 There already seems to be somewhat of a state machine in connection_or.h
 already, making `connection_or_change_state()` a potentially useful place
 to hook in.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27100#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online