[tor-bugs] #28144 [Applications/Tor Browser]: Update projects/tor-browser for Android

[Tor Bug Tracker & Wiki]

#28144: Update projects/tor-browser for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811, TBA-a2                   |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:34 gk]:

 > {{{
 > +cp $apk $base_apk-unsigned-unaligned.apk
 > }}}
 > Do we need the usigned-unaligned.apk here? What's its purpose in the
 final release directory? That said I think the .apk we produce before we
 do the final signing somewhere else (not just the dummy one in the tor-
 browser build script) should be something like `tor-browser-tbb-nightly-
 android-armv7.apk` (assuming we built a nightly version of it).

 When you sign and apk (either with jarsigner or apksigner) there two ways
 to do it:

  1. Specify input apk and signed output apk
  1. Sign the apk directly, overwriting the input file apk

 If we sign as (1), it would be clearer to leave the unsigned-unaligned in
 the file name. If we sign as (2), the apk of course will need to be
 renamed prior to signing. In case (2), It sound like we would want to redo
 the naming in the release project. I don't have any visibility as to how
 signing is done. Does a simple renaming of the unsigned apk in the release
 step work?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28144#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online