[tor-bugs] #22343 [Applications/Tor Browser]: Save as... in the context menu results in using the catch-all circuit

[Tor Bug Tracker & Wiki]

#22343: Save as... in the context menu results in using the catch-all circuit
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-linkability, tbb-usability,      |  Actual Points:
  ff52-esr, tbb-7.0-must, tbb-7.0-issues, tbb-   |
  regression, tbb-7.0-frequent,                  |
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:63 mcs]:
 > r=brade, r=mcs if you add a closing ')' to the first saveURL() call
 inside openLinkIn(). It definitely would be good to exercise that code.

 Phooey, thanks for catching that mistake. Here's the revised version:
 https://github.com/arthuredelstein/tor-browser/commit/22343+13

 The `if (where == "save")` block in that function seems likely to be dead
 code. But I am working on a script to exercise it and will report results
 here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22343#comment:65>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online