[tor-bugs] #27111 [Applications/Tor Browser]: TBA: Implement about:tor

[Tor Bug Tracker & Wiki]

#27111: TBA: Implement about:tor
-------------------------------------------------+-------------------------
 Reporter:  igt0                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 I updated the patch:

 https://github.com/igortoliveira/torbutton/commit/f5953aec52e8f9662c45cfff60cfe0b775ba43cb

 and I replied the comments bellow:

 Replying to [comment:7 sysrqb]:
 > Partially unrelated, but ideally, when the new tb-manual is available
 for TBA, then we'll probably need to adjust the URL construction within
 `src/chrome/content/aboutTor/aboutTor-content.js:onLocaleChange()`. (I
 guess this is similar to option 1 in #20739). We'll need a new mockup for
 this, too.
 >

 Oh nice catch. I will talk with Antonela about it.

 > ---
 >
 > In `src/chrome/content/torbutton.js:torbutton_init()`:
 > {{{
 > +    if (torbutton_is_mobile()) {
 > +        torbutton_abouttor_message_handler.updateAllOpenPages();
 > +    }
 > +
 > }}}
 > Can you add a comment about why this is needed only on mobile?

 Left over. I removed it.

 >
 > ----
 >
 >
 > We should set the homepage as `about:tor`, too. Fennec doesn't respect
 `browser.startup.homepage`, so we must hardcode it :/
 >
 > The easiest option may be modifying
 `mobile/android/base/java/org/mozilla/gecko/AboutPages.java:HOME`.
 Unfortunately, this won't work well until torbutton is integrated and
 there's no longer the need of restarting the app before torbutton fully
 installs. Another option is adding in a check for
 `browser.startup.homepage`, and that overrides `AboutPages:HOME`.
 >

 You are right. It is why I have a second patch for this bug where I add
 the following file to tor browser:

 mobile/android/torbrowser/assets/distribution/preferences.json

 {{{

 {
   "ApplicationPreferences": {
     "newtab.load_homepage": true
   },
   "AndroidPreferences": {
     "homepage": "about:tor",
     "startpane_enabled_after_57": true,
     "startpane_enabled": true
   }
 }

 }}}


 > ----
 >
 > This patch doesn't provide the same view as the mockup with the virtual
 keyboard opened (right-side of
 https://trac.torproject.org/projects/tor/attachment/ticket/25696/24309%20-%20TBA%20-%20Welcome%20Page.png).
 This'll require a tor-browser patch, as well, because Fennec automatically
 opens the ActivityStream HomePager every time the URL bar is focused.
 >

 Yes, In a follow up patch, I will remove the following method call from
 the BrowserApp.java


 {{{
 showHomePagerWithAnimator(panelId, null, animator);
 }}}


 > ----
 >
 > Overall, I don't see any problems with this torbutton patch. This should
 be reviewed by someone else (in particular someone with more knowledge of
 this code) - making sure this doesn't break anything on desktop. I'm
 setting to needs_revision because I think explaining why about:tor
 requires an explicit signal on mobile  during init() is helpful for
 reviewing this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27111#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online