[tor-bugs] #28027 [Core Tor/Tor]: Tor keeps opening circuits while waiting for bridge descriptors

[Tor Bug Tracker & Wiki]

#28027: Tor keeps opening circuits while waiting for bridge descriptors
-------------------------------------------+-------------------------------
 Reporter:  dgoulet                        |          Owner:  neel
     Type:  defect                         |         Status:  assigned
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.3.5.x-final
Component:  Core Tor/Tor                   |        Version:  Tor: 0.3.4.8
 Severity:  Normal                         |     Resolution:
 Keywords:  tor-hs, regression, tor-guard  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by neel):

 For this patch, I am thinking about the following:

  * If `UseBridges` was originally set to `0`, but then set to `1` later
 on, keep a flag in `feature/client/entrynodes.c`
  * Make `should_delay_dir_fetches()` check for this proposed flag if
 `UseBridges` is `1` to fetch the bridge descriptors, and if both are set,
 return `0`
  * In `options_act()`, initialize the proposed flag to 0 if we don't have
 `old_options`
  * In `options_act()`, if we have `old_options`, and
 `old_options->UseBridges` and `options->UseBridges` differ, set this flag
 to `1`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28027#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online