[tor-bugs] #28413 [Core Tor/Tor]: FreeBSD build warning in aes_new_cipher()

[Tor Bug Tracker & Wiki]

#28413: FreeBSD build warning in aes_new_cipher()
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  0             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Our jenkins freebsd builders are trying again!  And they are failing with:

 {{{
 18:20:41 ../tor/src/common/aes.c:107:14: error: variable 'c' is used
 uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-
 uninitialized]
 18:20:41     default: tor_assert(0); // LCOV_EXCL_LINE
 18:20:41              ^~~~~~~~~~~~~
 }}}

 Initializing c to NULL should solve this problem, which is IMO the
 compiler's fault.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28413>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online