[tor-bugs] #26540 [Applications/Tor Browser]: Enabling pdfjs disableRange option prevents pdfs from loading

Wed Nov 7 00:09:36 UTC 2018

#26540: Enabling pdfjs disableRange option prevents pdfs from loading
---------------------------------------------+-----------------------------
 Reporter:  pospeselr                        |          Owner:  pospeselr
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201811R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by pospeselr):

 Better patch following suggestions from Arthur, now using the secret
 chrome-only SetOriginAttributes function:

 https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_26540_v4

 The origin attributes are set immediately after channel creation, FPI
 regarding cookies is now enforced correctly, and pdfjs's range-based
 requests now go out on the correct channel (the channel for the hosted
 pdf's domain if entered directly in the title bar, and the first party
 domain's when embedded via an iframe or embed node).

 Verified on jsbin.com with the following html:

 {{{
 <!DOCTYPE html>
 <html>
 <body>
   <iframe
 src="http://cadwe.free.fr/cadr/DD4/Player%27s%20Handbook.pdf"></iframe>
 </body>
 </html>
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26540#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online