[tor-bugs] #28144 [Applications/Tor Browser]: Update projects/tor-browser for Android

[Tor Bug Tracker & Wiki]

#28144: Update projects/tor-browser for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201811, TBA-a2                   |
Parent ID:  #26693                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:9 sisbell]:
 > Replying to [comment:7 boklm]:
 > > Replying to [comment:5 gk]:
 > >
 > > >
 > > > For b) we usually have the bundling step (i.e. the tor-browser
 project). If that's not going to work (Is that the case? If so, why?) for
 Android (which would mean reopening the .apk we got in the firefox step
 and putting the extensions into place after building them if needed) we
 need to find a way doing that in the firefox build step and could do just
 the renaming in the tor-browser step.
 > > >
 > >
 > > However doing that in the firefox build means we need to rebuild
 firefox to update the extensions, so if that's possible, doing it in the
 `tor-browser` step would be better.
 > >
 > > It looks like .apk files are zip files, so I'm wondering if extracting
 them and adding the extensions in the right directory before rezipping the
 .apk file would work, or if there is something more needed.
 > To add assets, we can just use 'aapt add' command from the android SDK.
 We also need to make sure we resign the apk as part of a tor-browser step.
 We would do this with 'apksigner'.

 The app won't be signed within tor-browser-build, so that isn't a problem.
 We only must produce a valid unsigned-unaligned apk as the result.

 I agree adding the extensions in the tor-browser project (like we do for
 desktop) makes the most sense. We'll need to investigate what Mozilla do
 when a distribution is defined and replicate that in `build` - I haven't
 looked closely enough at this, so I don't know what is needed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28144#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online