[tor-bugs] #27841 [Core Tor/Tor]: Close intro circuit after introduction has been completed

[Tor Bug Tracker & Wiki]

#27841: Close intro circuit after introduction has been completed
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs dos 033-backport,             |  Actual Points:
  034-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * keywords:  tor-hs dos => tor-hs dos 033-backport, 034-backport


Comment:

 So this is a fix that probably applies back to 0.3.2.1-alpha I believe.
 Meaning the changes file is wrong and the branch should be based on
 maint-0.3.3 because I realized we are most likely to backport this fix
 since the re-extend optimization is busted.

 Now, on another note, I've discuss it with arma further on IRC and maybe
 actively closing the circuit is not ideal as in "we want to let the client
 decide what to do".

 Thus, it would simplify the patch, we just need to NOT close the circuit
 on NACK and that is it. We'll backport that fix.

 Sorry neel for the confusion. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27841#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online