[tor-bugs] #26812 [Core Tor/Tor]: hs: Adding client authorization through control port on an existing service fails

[Tor Bug Tracker & Wiki]

#26812: hs: Adding client authorization through control port on an existing service
fails
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  asn
     Type:  defect        |         Status:  merge_ready
 Priority:  High          |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:7 dgoulet]:
 > Replying to [comment:6 asn]:
 > > Thanks for review. I pushed a new branch `bug26812_v2` that addresses
 your comments, since the old one would not merge cleanly on master.
 > >
 > > Marking as merge_ready as requested, but feel free to re-review.
 >
 > Can you make a branch that is based on 035 so the CI can pass on it as
 well?
 >

 035 branch can be found here! https://github.com/torproject/tor/pull/477
 FWIW, I did not include the refactoring commit in the 035 branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26812#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online