[tor-bugs] #27367 [Core Tor/Tor]: Authorities should reject non-UTF-8 in relay descriptors

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 1 10:57:17 UTC 2018


#27367: Authorities should reject non-UTF-8 in relay descriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rust-wants, prop285,                 |  Actual Points:
  034-triage-20180328, 034-removed-20180328      |
Parent ID:  #24033                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM, but was missing tests for the new `no_bom` function. Other than
 that, looks sane and simple.

 I added some test in my branch `unicode-descriptors-dirauth2`.
 Also check out the PR: https://github.com/torproject/tor/pull/464
 (all new patches should come with a github PR).

 Marking as merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27367#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list