[tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR

[Tor Bug Tracker & Wiki]

#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by sukhbir):

 Replying to [comment:27 gk]:
 > Replying to [comment:26 gk]:
 > > Replying to [comment:22 sukhbir]:
 > > > EDIT: I guess I should have waited for Tor Browser to build as well.
 Firefox builds but Tor Browser gives an error. I am guessing this is
 related to the language packs so I will debug this later.
 > >
 > > Actually for some reason `(( count++ ))` in `common.sh` breaks now.
 I've pushed a follow-up commit to `tor-browser-60.0.1esr-8.0-1`
 (b135c59f65dba827b61379a4945251e148c43291) to unbreak us, but we should
 patch all instances of that and find out what the actual underlying issue
 is (looking at the log of changes to `common.sh` did not yield some
 obvious issue).
 >
 > I opened #26216 for that.

 Thanks, interesting catch. To confirm, I could build Linux x86_64 with the
 above branch submitted for review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online