[tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR

[Tor Bug Tracker & Wiki]

#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by sukhbir):

 https://github.com/azadi/tor-browser-build-1/tree/bug-26073

 This branch cherry-picks commits from Arthur's
 [https://github.com/arthuredelstein/tor-browser-build/commits/26073
 branch] but differs by fixing the LLVM signature check (which Arthur just
 merged.) So you can just merge his branch as most of the changes were
 lifted from there (and LLVM signature check was merged) but note that it
 doesn't use `master` on Tor Launcher and Torbutton, while the one above
 (bug-26073) does.

 This builds on Tor Browser:

 {{{
 +git_hash: '25543+10'
 +git_url: https://github.com/arthuredelstein/tor-browser.git
 }}}

 Linux builds fine but Windows fails with:

 {{{
 configure: processing command line
 configure:
 configure: error: Option 'CFLAGS=-mwindows -fstack-protector-all -Wstack-
 protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-
 field-initializers -Wformat -Wformat-security' is not recognized
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online