[tor-bugs] #26183 [Applications/Tor Launcher]: Close control connection (socket and io.streams) on failure

[Tor Bug Tracker & Wiki]

#26183: Close control connection (socket and io.streams) on failure
---------------------------------------+-----------------------
 Reporter:  cypherpunks                |          Owner:  brade
     Type:  defect                     |         Status:  new
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:                             |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------

Comment (by cypherpunks):

 {{{
     catch(e)
     {
       TorLauncherLogger.safelog(4,
                              "failed to open authenticated connection: ",
 e);
 +     if (conn)
 +       this._closeConnection(conn);
       return null;
     }
 }}}
 {{{
       if (!this.TorCommandSucceeded(reply))
       {
         TorLauncherLogger.log(4, "authenticate failed");
 +       this._closeConnection(conn);
         return null;
       }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26183#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online