[tor-bugs] #26116 [Core Tor/Tor]: OpenSSL 1.1.1 changed the semantics of the password callback return value

Wed May 23 22:57:41 UTC 2018

#26116: OpenSSL 1.1.1 changed the semantics of the password callback return value
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-backport 031-backport            |  Actual Points:
  032-backport 033-backport                      |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready

Comment:

 Looks mostly good.  It looks like no tests are currently calling the
 callback?  Is there ever a case where we expect to handle a password-
 protected key through these functions?  If so, maybe we want to add a
 test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26116#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online