[tor-bugs] #25886 [Core Tor/Tor]: Have frac_nodes_with_descriptors() take and use for_direct_connect

[Tor Bug Tracker & Wiki]

#25886: Have frac_nodes_with_descriptors() take and use for_direct_connect
--------------------------+----------------------------------
 Reporter:  nickm         |          Owner:  neel
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------
Changes (by neel):

 * owner:  (none) => neel
 * cc: neel@… (added)
 * status:  new => assigned


Comment:

 I am interested in this ticket. However, I have a question:

 When I add `for_direct_conn` in `frac_nodes_with_descriptors()`, should I
 replace instances of `node_has_any_descriptor()` with
 `node_has_preferred_descriptor()` and pass in `for_direct_conn` (and
 modifying instances for `frac_nodes_with_descriptors()` to add
 `for_direct_conn`)? Is there more that I need to do?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25886#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online