[tor-bugs] #26022 [Metrics/Statistics]: Fix a flaw in the noise-removing code in our onion service statistics

[Tor Bug Tracker & Wiki]

#26022: Fix a flaw in the noise-removing code in our onion service statistics
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  defect              |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:4 asn]:
 > Replying to [comment:3 karsten]:
 > > Replying to [comment:2 asn]:
 > > If the answers above make sense and you agree that this is a possible
 bug, I'll try to produce numbers using the fixed method.
 >
 > Yes, this does seem like a possible bug. Thanks for helping me
 understand. Would you like to try to produce numbers using the fixed
 method?

 Okay, I produced numbers using the fixed method for the time in 2018 so
 far, and the change is hardly visible. That's why I put the new numbers in
 relation to old numbers here:

 [[Image(hidserv-change-task-26022.png​, 700px)]]

 > As a final review step, we could also send a small email to Aaron
 Johnson, so that he can also verify the logic here.

 I did copy an ohmygodel person on this ticket, but I might have misspelled
 that pseudonym, or Trac email did not work for some reason. I'll send him
 a good old email to let him know.

 So, I'd say this is not a big thing. However, we should fix it anyway, and
 we should be sure not to make the same mistake again in PrivCount. After
 all, this is not Java-specific. It's related to how integers are
 truncated, which is likely the same in other programming languages.
 Another good reason to let Aaron know.

 If the plan to fix this small bug seems reasonable, I'll do that in the
 next few days. It's going to be that one-line change from the ticket
 summary.

 Thanks, asn!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26022#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online