[tor-bugs] #24658 [Core Tor/Tor]: Split/refactor crypto.h into smaller separate modules
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri May 11 18:59:19 UTC 2018
#24658: Split/refactor crypto.h into smaller separate modules
-------------------------------------------------+-------------------------
Reporter: isis | Owner:
| ffmancera
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-crypto, refactor, review- | Actual Points:
group-32, review-group-34, |
033-triage-20180320, 033-included-20180320 |
Parent ID: | Points:
Reviewer: nickm, isis | Sponsor:
| Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by isis):
* status: needs_review => needs_revision
Comment:
I've left my review [https://github.com/torproject/tor/pull/105 here].
There's just a couple small changes that need to be addressed. For the
moved code, I've verified it's identical using a mix between good ol'
`diff` and `git show -p --color-moved`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24658#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list