[tor-bugs] #26069 [Core Tor/Tor]: hs-v3: Descriptor signature parsing should have a trailing white-space
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu May 10 13:11:37 UTC 2018
#26069: hs-v3: Descriptor signature parsing should have a trailing white-space
-------------------------+-------------------------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: assigned
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core | Version:
Tor/Tor | Keywords: 031-backport, 032-backport,
Severity: Normal | 033-backport, tor-hs
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
-------------------------+-------------------------------------------------
From ticket #25552, nickm's comment:
I've reviewed the PR. The biggest issue is related to the use of "\n"
signature_str, which I believe should be "\n" signature_str " " instead.
We'll fix it in #25552 for 034 but we need to backport it back to 030 when
it was first introduced. It won't affect any tor version on the ability to
parse service descriptors. It will just reinforce the security and
correctness.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26069>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list