[tor-bugs] #25761 [Core Tor/Tor]: hs: Reload signal (HUP) doesn't remove a disabled service

[Tor Bug Tracker & Wiki]

#25761: hs: Reload signal (HUP) doesn't remove a disabled service
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  032-backport, 033-backport, tor-hs,  |  Actual Points:
  regression                                     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 I think the fix here is to initialize `rend_service_staging_list` in
 `rend_service_prune_list()` instead of exiting the function:

 {{{
   if (!rend_service_staging_list) {
 -     return;
 +     rend_service_staging_list = smartlist_new();
   }
 }}}

 dgoulet what you think? does this fit the whole staging/pruning logic?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25761#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online