[tor-bugs] #24031 [Core Tor/Tor]: Protover.rs could use a better algorithm

[Tor Bug Tracker & Wiki]

#24031: Protover.rs could use a better algorithm
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  isis
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, 033-must, protover, security,  |  Actual Points:  5
  033-triage-20180326, 033-included-20180326     |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorM-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:21 nickm]:
 > Also -- could I have this as a github pull request, or failing that, as
 a gitlab pull request?  I'd like to try reviewing this with a UI, since
 the patch series is >3k lines long :)

 Yep! Will submit to Github? (Wow, this is new.) Should I make an actual PR
 to https://github.com/torproject/tor? Or would you prefer oniongit's
 interface?

 I found a few more small problems with differences to the C implementation
 that I want to fix, but I should have the patches/tests done today.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24031#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online