[tor-bugs] #25629 [Core Tor/Tor]: fix CID 1430932

[Tor Bug Tracker & Wiki]

#25629: fix CID 1430932
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:
                                                 |  catalyst
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  033-must regression 029-backport     |  Actual Points:
  031-backport 032-backport 033-triage-20180326  |
  033-included-20180326                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  assigned => needs_review


Old description:



New description:

 Coverity found a null pointer reference in nodelist_add_microdesc().
 This is almost certainly impossible assuming that the routerstatus_t
 returned by router_get_consensus_status_by_descriptor_digest() always
 corresponds to an entry in the nodelist.

--

Comment:

 Added description.  Pull requests with patches:

 0.2.9 and 0.3.1: https://github.com/torproject/tor/pull/30

 0.3.2: https://github.com/torproject/tor/pull/31

 0.3.3 and master: https://github.com/torproject/tor/pull/32

 0.2.9 merges cleanly to 0.3.1; 0.3.3 merges cleanly to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25629#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online