[tor-bugs] #25055 [Core Tor/Tor]: string_is_valid_hostname() returns true for IPv4 addresses

[Tor Bug Tracker & Wiki]

#25055: string_is_valid_hostname() returns true for IPv4 addresses
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  IPv6, IPv4, tor-dns, 032-backport,   |  Actual Points:
  033-must, review-group-34,                     |
  033-triage-20180320, 033-included-20180320     |
Parent ID:  #25036                               |         Points:  1
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 nickm: Naming this appropriately is a good idea. I like
 string_is_valid_nonrfc_hostname() and a warning comment. Technically the
 function allows things like luck.y13 (which is explicitly tested in the
 unit tests), but that is not any kind of valid DNS name or IP.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25055#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online