[tor-bugs] #20301 [Applications/Tor Browser]: Bumping the compiler version to 6.2.0 breaks 64bit Tor Browser builds
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Mar 20 14:32:24 UTC 2018
#20301: Bumping the compiler version to 6.2.0 breaks 64bit Tor Browser builds
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Blocker | Resolution:
Keywords: GeorgKoppen201610, tbb-rbm, | Actual Points:
boklm201803, TorBrowserTeam201803R |
Parent ID: #25304 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:15 boklm]:
> Replying to [comment:3 gk]:
> > Okay, I bisected the problem (`PIE` enforcement breaks the compiler)
and pushed a fix for review to bug_20301
(https://gitweb.torproject.org/user/gk/tor-browser-
bundle.git/commit/?h=bug_20301&id=dfa3403825fc315168df3295f6062f5979b0a8a0)
in my public repo.
>
> I applied the same fix, using the same comment, to tor-browser-build in
branch `bug_20301`:
> https://gitweb.torproject.org/user/boklm/tor-browser-
build.git/commit/?h=bug_20301&id=4e57f8a0780fd9ed9633dc7d2391bf908b74e337
The comment looks good to me. Although, we won't update GCC to 6.2.0
anymore. Thus, the commit message is wrong. I think we should just close
this bug an apply the comment about disabling PIE in the upcoming patch
for #25304.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20301#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list