[tor-bugs] #16849 [Core Tor/Tor]: clear_status_flags_on_sybil might want to clear more flags

[Tor Bug Tracker & Wiki]

#16849: clear_status_flags_on_sybil might want to clear more flags
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  ffmancera
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, SponsorS-deferred, technical-  |  Actual Points:
  debt, tor-dirauth, pending-disaster, review-   |
  group-32, review-group-34                      |
Parent ID:                                       |         Points:  small
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Hm.  I think this is probably correct, but I wonder if it could be even
 more simple.

 My main concern with this patch now is that we have a new failure mode:
 instead of maybe forgetting to clear a flag, we can now maybe forget to
 preserve a field.

 Either approach would be okay if we could come up with some kind of unit
 test that ensures that we haven't missed any fields.  I think we could
 build one -- just a second...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16849#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online