[tor-bugs] #25291 [Core Tor/Tor]: get rid of redundant should_record_bridge_info() call in options_act()

[Tor Bug Tracker & Wiki]

#25291: get rid of redundant should_record_bridge_info() call in options_act()
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  enhancement   |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 Neel: this patch looks correct to me too. But...

 Roger, I am actually thinking that maybe we should not make this change.
 In my opinion, checking `should_record_bridge_info()` is a good idea, in
 case we ever want to change its semantics, or earlier block of the
 function, in the future.  What do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25291#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online