[tor-bugs] #25479 [Core Tor/Tor]: Fix win32 crash in bench.c

[Tor Bug Tracker & Wiki]

#25479: Fix win32 crash in bench.c
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core     |    Version:  Tor: 0.2.6.1-alpha
  Tor/Tor                |   Keywords:  windows, tor-tests, 033-must,
     Severity:  Normal   |  review-group-36
Actual Points:           |  Parent ID:
       Points:  .2       |   Reviewer:  isis
      Sponsor:           |
-------------------------+-------------------------------------------------
 On the mailing lists, Gisle Vanem [https://lists.torproject.org/pipermail
 /tor-dev/2018-March/012998.html reported] a crash while running
 `bench.exe` on a windows system. On first sight, it appeared to be
 possibly related to calling `options_new()` from `bench.c`'s `main()`, but
 Gisle [https://lists.torproject.org/pipermail/tor-
 dev/2018-March/013005.html provided a patch] which reportedly fixes the
 crash by calling `init_protocol_warning_severity_level()` which instead
 suggests that the crash was due to calling `init_logging()` (which calls
 `tor_mutex_init()`, which then calls `InitializeCriticalSection()`). The
 [https://msdn.microsoft.com/en-
 us/library/windows/desktop/ms683472(v=vs.85).aspx MSDN documentation] for
 `InitializeCriticalSection()` states that has slightly different
 behaviours during edge cases for different windows flavours, so that could
 possibly have been the cause of the issue?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25479>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online