[tor-bugs] #25241 [Metrics/Onionoo]: effective_family sometimes contains the relay's own fingerprint

[Tor Bug Tracker & Wiki]

#25241: effective_family sometimes contains the relay's own fingerprint
-----------------------------+--------------------------------
 Reporter:  irl              |          Owner:  karsten
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Onionoo 1.11.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+--------------------------------

Comment (by iwakeh):

 Replying to [comment:15 karsten]:
 > Replying to [comment:14 iwakeh]:
 > > Open steps:
 > >
 > > * decide for adding 'self' always to the effective family, because
 clients (like RS) interpret it like that (and had to work around the
 inconsistent situation so far) or against it because it would add too much
 to current documents
 >
 > I'm fine with this. From comments above it sounds like there are no
 concerns. Let's do it.
 >
 > > * explicitly state whether the relay belongs to its effective family
 or not in the protocol (if not it should also explicitly be added that the
 'self' doesn't show up in the other two family types either)
 > > * make & merge the appropriate changes (everywhere)
 >
 > Do you want to do this? I just reviewed
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git/commit/?h=task-25241&id=df11f4de038c31f33c3f6e231854887995271201
 your task-25241 branch until commit df11f4d]. Looks good! Do you want to
 change it to always add a relays own fingerprint to its declared family?
 And I guess we'll squash those commits in the end, to avoid making a
 change and undoing it right afterwards.
 >
 > If you're already juggling too many tickets, I can also take this one.
 Let me know.

 You might be more efficient on this task because the tests need to be
 adapted; and you reviewed my suggested branch already, in which only small
 simple changes will be necessary.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25241#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online