[tor-bugs] #17901 [Core Tor/Tor]: Tor would bind ControlPort to public ip address if it has no localhost interface

[Tor Bug Tracker & Wiki]

#17901: Tor would bind ControlPort to public ip address if it has no localhost
interface
-------------------------------------------------+-------------------------
 Reporter:  s7r                                  |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.10
 Severity:  Major                                |     Resolution:
 Keywords:  tor-control misconfiguration         |  Actual Points:
  security easy                                  |
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 To answer your question on #tor-dev:

 If you implement the new check as part of tor\_addr_is_local(), add a
 for\_listening flag like tor\_addr\_is\_internal(), and out your new code
 behind that flag:
 https://gitweb.torproject.org/tor.git/tree/src/common/address.c#n353

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17901#comment:48>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online