[tor-bugs] #25245 [Core Tor/Tor]: Crash in assert_connection_ok when changing Exit options

[Tor Bug Tracker & Wiki]

#25245: Crash in assert_connection_ok when changing Exit options
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  crash, regression?, tor-exit, tor-   |  Actual Points:
  relay, ipv6                                    |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by toralf):

 And with the opposite order in applying first the 0.3.3.3->0.3.4 and then
 your patch I get this picture :
 {{{
 Mar 11 21:03:15.000 [err] tor_assertion_failed_(): Bug:
 src/or/connection.c:5114: assert_connection_ok: Assertion
 connection_is_writing(conn) || conn->write_blocked_on_bw failed; aborting.
 (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug: Assertion connection_is_writing(conn) ||
 conn->write_blocked_on_bw failed in assert_connection_ok at
 src/or/connection.c:5114. Stack trace: (on Tor 0.3.4.0-alpha-dev
 d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(log_backtrace+0x53)
 [0x55c4d18a3513] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:
 /usr/bin/tor(tor_assertion_failed_+0x99) [0x55c4d18c0559] (on Tor 0.3.4.0
 -alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:
 /usr/bin/tor(assert_connection_ok+0x86b) [0x55c4d181de8b] (on Tor 0.3.4.0
 -alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(+0x152b4b)
 [0x55c4d1863b4b] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/lib64/libevent-2.1.so.6(+0x3329d)
 [0x7f5327c1829d] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/lib64/libevent-2.1.so.6(+0x244d0)
 [0x7f5327c094d0] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:
 /usr/lib64/libevent-2.1.so.6(event_base_loop+0x53f) [0x7f5327c0a48f] (on
 Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(do_main_loop+0x26c)
 [0x55c4d17656dc] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(tor_run_main+0x27d)
 [0x55c4d1766d5d] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(tor_main+0x49)
 [0x55c4d175fd79] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(main+0x28)
 [0x55c4d175faa8] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:
 /lib64/libc.so.6(__libc_start_main+0xfd) [0x7f532677c5ad] (on Tor 0.3.4.0
 -alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:03:15.000 [err] Bug:     /usr/bin/tor(_start+0x2a)
 [0x55c4d175fafa] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 }}}
 and
 {{{
 Mar 11 21:02:24.000 [err] tor_assertion_failed_(): Bug:
 src/or/connection.c:5114: assert_connection_ok: Assertion
 connection_is_writing(conn) || conn->write_blocked_on_bw failed; aborting.
 (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug: Assertion connection_is_writing(conn) ||
 conn->write_blocked_on_bw failed in assert_connection_ok at
 src/or/connection.c:5114. Stack trace: (on Tor 0.3.4.0-alpha-dev
 d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(log_backtrace+0x53)
 [0x559eb6f5e513] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:
 /usr/bin/tor(tor_assertion_failed_+0x99) [0x559eb6f7b559] (on Tor 0.3.4.0
 -alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:
 /usr/bin/tor(assert_connection_ok+0x86b) [0x559eb6ed8e8b] (on Tor 0.3.4.0
 -alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(+0x152b4b)
 [0x559eb6f1eb4b] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/lib64/libevent-2.1.so.6(+0x3329d)
 [0x7ff26e1a729d] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/lib64/libevent-2.1.so.6(+0x244d0)
 [0x7ff26e1984d0] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:
 /usr/lib64/libevent-2.1.so.6(event_base_loop+0x53f) [0x7ff26e19948f] (on
 Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(do_main_loop+0x26c)
 [0x559eb6e206dc] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(tor_run_main+0x27d)
 [0x559eb6e21d5d] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(tor_main+0x49)
 [0x559eb6e1ad79] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(main+0x28)
 [0x559eb6e1aaa8] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:
 /lib64/libc.so.6(__libc_start_main+0xfd) [0x7ff26cd0b5ad] (on Tor 0.3.4.0
 -alpha-dev d15a7a27bb9e49bd)
 Mar 11 21:02:24.000 [err] Bug:     /usr/bin/tor(_start+0x2a)
 [0x559eb6e1aafa] (on Tor 0.3.4.0-alpha-dev d15a7a27bb9e49bd)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25245#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online