[tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,       |  Actual Points:
  boklm201803                                    |
Parent ID:  #12968                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201803R, boklm201803 => tbb-rbm,
     TorBrowserTeam201803, boklm201803


Comment:

 I made test builds with your patch but both the 32bit and the 64bit
 bundles are crashing for me right on start. In the debugger I see tons of
 messages like
 {{{
 warning: 0f64:0944 @ 01846240 - LdrpSnapThunk - WARNING: Hint index 0x119
 for pr
 ocedure "NtEnumerateKey" in DLL "ntdll.dll" is invalid

 warning: 0f64:0944 @ 01846256 - LdrpSnapThunk - WARNING: Hint index 0x3bb
 for pr
 ocedure "RtlIntegerToUnicodeString" in DLL "ntdll.dll" is invalid

 warning: 0f64:0944 @ 01846287 - LdrpSnapThunk - WARNING: Hint index 0x26e
 for pr
 ocedure "RtlAppendUnicodeStringToString" in DLL "ntdll.dll" is invalid

 warning: 0f64:0944 @ 01846303 - LdrpSnapThunk - WARNING: Hint index 0x4a7
 for pr
 ocedure "RtlStringFromGUID" in DLL "ntdll.dll" is invalid
 }}}.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16472#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online