[tor-bugs] #25415 [Core Tor/Tor]: moria1 seg faults on testing relay reachability

[Tor Bug Tracker & Wiki]

#25415: moria1 seg faults on testing relay reachability
--------------------------+------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by arma):

 Confirmed. I added this patch:
 {{{
 diff --git a/src/or/dirserv.c b/src/or/dirserv.c
 index 0f47a83..0a9420f 100644
 --- a/src/or/dirserv.c
 +++ b/src/or/dirserv.c
 @@ -3393,6 +3393,7 @@ dirserv_single_reachability_test(time_t now,
 routerinfo_t

    if (options->AuthDirTestEd25519LinkKeys &&
        node_supports_ed25519_link_authentication(node, 1)) {
 +    tor_assert(router->cache_info.signing_key_cert);
      ed_id_key = &router->cache_info.signing_key_cert->signing_key;
    } else {
      ed_id_key = NULL;
 }}}

 and it triggers the assert.

 {{{
 (gdb) up
 #2  0x00007ffff7c34316 in dirserv_single_reachability_test (
     now=<value optimized out>, router=0x7fffeb96c880) at
 src/or/dirserv.c:3396
 3396        tor_assert(router->cache_info.signing_key_cert);
 (gdb) print router->cache_info
 $1 = {signed_descriptor_body = 0x0, annotations_len = 57,
   signed_descriptor_len = 1648,
   signed_descriptor_digest =
 "õÃ\200\227:Ë\226\225\217Õv\035Pk¯­\215\202³ó",
   identity_digest = "\fÚ0ÍÛRku>K§\t8p;ïl´¸á", published_on = 1520082806,
   extra_info_digest = "\216\214·¬ Æ1Su}m\203ÆÅVÔÑõ\217¤",
   extra_info_digest256 = '\000' <repeats 31 times>, signing_key_cert =
 0x0,
   ei_dl_status = {next_attempt_at = 0, n_download_failures = 0 '\000',
     n_download_attempts = 0 '\000', schedule = DL_SCHED_GENERIC,
     want_authority = DL_WANT_ANY_DIRSERVER,
     increment_on = DL_SCHED_INCREMENT_FAILURE,
     last_backoff_position = 0 '\000', last_delay_used = 0},
   saved_location = SAVED_IN_CACHE, saved_offset = 39789237,
   routerlist_index = 324, last_listed_as_valid_until = 0, do_not_cache =
 0,
   is_extrainfo = 0, extrainfo_is_bogus = 0, send_unencrypted = 1}
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25415#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online