[tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

[Tor Bug Tracker & Wiki]

#25400: CIRC_BW event miscounts, should count all circ data
--------------------------+------------------------------------
 Reporter:  mikeperry     |          Owner:  mikeperry
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-stats     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by mikeperry):

 Another additional wrinkle to discuss: I chose to use CELL_PAYLOAD_SIZE as
 the number of bytes to count per cell. That value is the total bytes in a
 cell, less cell header size. I also briefly debated subtracting the common
 relay header size, but since the true relay header size varies by relay
 cell type, I decided not to subtract the common relay header from the
 totals. The Tor controller can decide to subtract the common relay header
 out itself (as it represents a constant rate of overhead). The vanguards
 controller will do this subtraction.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25400#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online