[tor-bugs] #26541 [Core Tor/Tor]: Fix minor mistakes in the bandwidth-file dir-spec entry

[Tor Bug Tracker & Wiki]

#26541: Fix minor mistakes in the bandwidth-file dir-spec entry
---------------------------------+------------------------------------
 Reporter:  teor                 |          Owner:  juga
     Type:  defect               |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  tor-bwauth, torspec  |  Actual Points:
Parent ID:  #3723                |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:8 atagar]:
 > > The definition is missing ArgumentCharValue, which does not appear
 anywhere else in dir-spec.txt:
 >
 > I'm not overly much a fan of the package line's spec but you could use
 the NONSPACE from it (that's what you described here). Personally I prefer
 more limited field definitions like shared-rand-commit's...
 >
 > {{{
 > AlgName ::= 1*(ALPHA / DIGIT / "_" / "-")
 > }}}
 >
 > But up to you on how broad you want the allowable values of these fields
 to be.

 It's up to juga if they want to make this change.

 At the moment, our sample data contains:
 {{{
 ArgumentCharValue ::= ALPHA / DIGIT / "_" / "-" / "$" / "." / "/" / ":" /
 "+"
 }}}
 https://gitweb.torproject.org/torspec.git/tree/bandwidth-file-
 spec.txt#n436

 If we restrict the set of allowed characters:
 * we make it harder to add extra header lines, particularly if their
 values are copied from other systems, and
 * we make the code in #3723 more complicated.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26541#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online