[tor-bugs] #3569 [Core Tor/Tor]: Refactor socks parsing

[Tor Bug Tracker & Wiki]

#3569: Refactor socks parsing
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client intro trunnel prop229     |  Actual Points:
  refactor code-quality                          |
Parent ID:                                       |         Points:  4
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This branch is looking very nice.  I left a few small suggestions and
 requests on the github pull request.

 And as I noted on the review, please ignore any comments that you
 addressed later in your branch.  There are a lot of times when I said
 "this needs documentation" and later you documented it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3569#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online