[tor-bugs] #26503 [Core Tor/Tor]: src/lib/err/torerr.c missing STDERR_FILENO on Windows after refactor

[Tor Bug Tracker & Wiki]

#26503: src/lib/err/torerr.c missing STDERR_FILENO on Windows after refactor
------------------------------+-----------------------------------------
     Reporter:  catalyst      |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  regression, tor-ci, windows
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------------------------------
 The Windows Jenkins builds seem to be failing on master due to the
 torerr.c refactor:
 https://jenkins.torproject.org/view/Failed+Unstable/job/tor-ci-windows-
 master/1962/consoleFull
 {{{
 18:59:29 depbase=`echo src/lib/err/torerr.o | sed
 's|[^/]*$|.deps/&|;s|\.o$||'`;\
 18:59:29        gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../tor  -I../tor/src
 -I../tor/src/ext -I../tor/src/ext/trunnel -I../tor/src/trunnel
 -I../tor/src/ext -Isrc/ext -DSHARE_DATADIR="\"/usr/share\""
 -DLOCALSTATEDIR="\"/usr/var\"" -DBINDIR="\"/usr/bin\""
 -I../UPSTREAM/usr/include -I../UPSTREAM/usr/include
 -I../UPSTREAM/usr/include  -g -O2 -Wno-error=redundant-decls
 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wstack-
 protector -fasynchronous-unwind-tables -Wall -fno-strict-aliasing
 -Waddress -Warray-bounds -Wdouble-promotion -Wextra -Winit-self -Wlogical-
 op -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-
 noreturn -Woverlength-strings -Woverride-init -Wshadow -Wsync-nand
 -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-variable
 -Wunused-local-typedefs -Wvariadic-macros -W -Wfloat-equal -Wundef
 -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings
 -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings
 -Wnested-externs -Wbad-function-cast -Wswitch-enum -Waggregate-return
 -Wpacked -Wunused -Wunused-parameter  -Wold-style-definition -Wmissing-
 declarations -Werror -MT src/lib/err/torerr.o -MD -MP -MF $depbase.Tpo -c
 -o src/lib/err/torerr.o ../tor/src/lib/err/torerr.c &&\
 18:59:29        mv -f $depbase.Tpo $depbase.Po
 18:59:29 ../tor/src/lib/err/torerr.c:35:57: error: 'STDERR_FILENO'
 undeclared here (not in a function)
 18:59:29 make[1]: *** [src/lib/err/torerr.o] Error 1
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26503>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online