[tor-bugs] #26319 [Applications/Tor Browser]: Don't package up the whole Tor Browser in the `mach package` step

[Tor Bug Tracker & Wiki]

#26319: Don't package up the whole Tor Browser in the `mach package` step
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806,      |  Actual Points:
  tbb-rbm                                        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sukhbir):

 For review:

 https://github.com/azadi/tor-browser-build-1/commits/bug-26319

 From the commit message:

 {{{
 Bug 26319: Don't package up the whole Tor Browser in the `mach package`
 step

 This commit sets `mach build stage-package` instead of `mach package` in
 the Firefox build; this helps us to use the useful properties of `mach
 package` but avoids creating the final DMG or EXE during the Firefox
 build which we don't want as we do that later when building Tor Browser.

 We no longer need to patch `installer.py` (bug 26205) but we still need
 the patch for the uninstaller otherwise the Firefox build fails trying
 to find the required NSIS files.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26319#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online